Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1153433003: Merge to M44: "Drop frames less than a millisecond apart in media time." (Closed)

Created:
5 years, 7 months ago by DaleCurtis
Modified:
5 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

Merge to M44: "Drop frames less than a millisecond apart in media time." Our rendering path has no reasonable expectation of being able to render 1000fps content, so these are bad timestamps that end up wrecking assumptions throughout the rendering pathway. Instead of trying to guard against these frames everywhere, just discard them immediately during enqueue. BUG=488302 TEST=new unittest TBR=xhwang Review URL: https://codereview.chromium.org/1142723002 Cr-Commit-Position: refs/heads/master@{#330458} (cherry picked from commit b5814778060deb32c31605bfe0b82cd2baeae866)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -25 lines) Patch
M media/filters/video_renderer_algorithm.cc View 1 chunk +22 lines, -17 lines 0 comments Download
M media/filters/video_renderer_algorithm_unittest.cc View 3 chunks +27 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaleCurtis
5 years, 7 months ago (2015-05-21 01:29:49 UTC) #1
DaleCurtis
5 years, 7 months ago (2015-05-21 01:30:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
cbd73b2480cd9c0162bca8ec8e0714a45921b2ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698