Issue 1153413003: Fix min/max typo in BoxConstraints.deflate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153413003: Fix min/max typo in BoxConstraints.deflate (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix min/max typo in BoxConstraints.deflate R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3fd856dfa1f59500fe45e2231d259406f1c9fc16

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	sky/sdk/lib/framework/rendering/box.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sky/tests/raw/padding_deflate.dart	View	1 chunk	+9 lines, -8 lines	0 comments	Download
A +	sky/tests/raw/padding_deflate-expected.txt	View	1 chunk	+1 line, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1153413003/diff/1/sky/tests/raw/padding_deflate-expected.txt File sky/tests/raw/padding_deflate-expected.txt (left): https://codereview.chromium.org/1153413003/diff/1/sky/tests/raw/padding_deflate-expected.txt#oldcode8 sky/tests/raw/padding_deflate-expected.txt:8: 1 | | drawRect(0.0:0.0:600.0:800.0, Paint(0xff00ff00)) I would leave ...

5 years, 6 months ago (2015-06-03 18:11:02 UTC) #2

eseidel

5 years, 6 months ago (2015-06-03 18:12:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3fd856dfa1f59500fe45e2231d259406f1c9fc16 (presubmit successful).

Expand Messages | Collapse Messages