sky/sdk/lib/framework/rendering/box.dart - Issue 1153413003: Fix min/max typo in BoxConstraints.deflate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/rendering/box.dart

Issue 1153413003: Fix min/max typo in BoxConstraints.deflate (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/framework/rendering/box.dart

diff --git a/sky/sdk/lib/framework/rendering/box.dart b/sky/sdk/lib/framework/rendering/box.dart

index 100219477b9e13b750ad812f20c20636e9065313..f6bb40bf0484012044dd904d444cf13b4650eb8a 100644

--- a/sky/sdk/lib/framework/rendering/box.dart

+++ b/sky/sdk/lib/framework/rendering/box.dart

@@ -55,9 +55,9 @@ class BoxConstraints {

double horizontal = edges.left + edges.right;

double vertical = edges.top + edges.bottom;

return new BoxConstraints(

- minWidth: math.min(0.0, minWidth - horizontal),

+ minWidth: math.max(0.0, minWidth - horizontal),

maxWidth: maxWidth - horizontal,

- minHeight: math.min(0.0, minHeight - vertical),

+ minHeight: math.max(0.0, minHeight - vertical),

maxHeight: maxHeight - vertical

);

}