Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1153413002:
Fix compile failure for AIX (Closed)
|
Created:
5 years, 6 months ago by mhdawsonibm Modified:
5 years, 6 months ago CC:
v8-dev Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionFix compile failure for AIX
Fix another may be uninitialized compile failure on AIX
in src/heap/heap.cc
BUG=
Patch Set 1 #
Messages
Total messages: 16 (5 generated)
mhdawsonibm@gmail.com changed reviewers: + mbrandy@us.ibm.com, svenpanne@chromium.org
Another case of missing initialization for AIX
lgtm
The CQ bit was checked by svenpanne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153413002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3038)
The CQ bit was checked by svenpanne@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153413002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3046)
You need to use your <*@*.ibm.com> email address, otherwise the CL will complain...
On 2015/05/29 09:54:06, Sven Panne wrote: > You need to use your <mailto:*@*.ibm.com> email address, otherwise the CL will > complain... Sigh, I had added an email to my existing account in order to work around an problem with another system not liking my michael_dawson@ca.ibm.com account. That seems to have made the new email the primary and even when I sign in with the right email it uses the new address. I've deleted the new email but it does not look like it will change the created by email on this review.
On 2015/05/29 14:22:06, michael_dawson wrote: > On 2015/05/29 09:54:06, Sven Panne wrote: > > You need to use your <mailto:*@*.ibm.com> email address, otherwise the CL will > > complain... > > Sigh, I had added an email to my existing account in order to work around an > problem with another system not liking my mailto:michael_dawson@ca.ibm.com account. > That seems to have made the new email the primary and even when I sign in with > the right email it uses the new address. I've deleted the new email but it does > not look like it will change the created by email on this review. Worse now I don't seem to be able to edit this one review anymore. I guess I'll have to submit a new one.
On 2015/05/29 14:23:23, michael_dawson wrote: > On 2015/05/29 14:22:06, michael_dawson wrote: > > On 2015/05/29 09:54:06, Sven Panne wrote: > > > You need to use your <mailto:*@*.ibm.com> email address, otherwise the CL > will > > > complain... > > > > Sigh, I had added an email to my existing account in order to work around an > > problem with another system not liking my mailto:michael_dawson@ca.ibm.com > account. > > That seems to have made the new email the primary and even when I sign in with > > the right email it uses the new address. I've deleted the new email but it > does > > not look like it will change the created by email on this review. > > Worse now I don't seem to be able to edit this one review anymore. I guess I'll > have to submit a new one. Replaced with https://codereview.chromium.org/1153233004/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
