Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1153373003: Add new Float32x4 type for SIMD.js. (Closed)

Created:
5 years, 6 months ago by bbudge
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add new Float32x4 type for SIMD.js. LOG=N BUG=v8:4124 Committed: https://crrev.com/f9dd3446da82fbbf20c344ceb6a87be2c11f5759 Cr-Commit-Position: refs/heads/master@{#28797}

Patch Set 1 : #

Patch Set 2 : Rebase. #

Patch Set 3 : Add snapshot support for SIMD. #

Patch Set 4 : #

Patch Set 5 : A little more testing. #

Patch Set 6 : A few more tests. #

Total comments: 14

Patch Set 7 : Review comments. #

Total comments: 2

Patch Set 8 : Improve lane tests. #

Patch Set 9 : Rebase. #

Patch Set 10 : Fix int type mismatches. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -6 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -2 lines 0 comments Download
M include/v8-profiler.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -0 lines 0 comments Download
M src/globals.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-snapshot-generator.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 7 8 2 chunks +27 lines, -0 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 6 chunks +29 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 4 chunks +14 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 6 7 8 5 chunks +33 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 5 6 7 8 9 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
bbudge
I could keep playing with this but I think I need some V8 expertise now.
5 years, 6 months ago (2015-06-03 01:12:12 UTC) #4
Hannes Payer (out of office)
hi bill, what the question?
5 years, 6 months ago (2015-06-03 06:16:52 UTC) #5
Hannes Payer (out of office)
On 2015/06/03 06:16:52, Hannes Payer wrote: > hi bill, what the question? what's
5 years, 6 months ago (2015-06-03 06:17:13 UTC) #6
Hannes Payer (out of office)
On 2015/06/03 06:17:13, Hannes Payer wrote: > On 2015/06/03 06:16:52, Hannes Payer wrote: > > ...
5 years, 6 months ago (2015-06-03 06:20:33 UTC) #7
bbudge
On 2015/06/03 06:16:52, Hannes Payer wrote: > hi bill, what the question? I guess my ...
5 years, 6 months ago (2015-06-03 12:12:43 UTC) #8
titzer
https://codereview.chromium.org/1153373003/diff/140001/src/factory.h File src/factory.h (right): https://codereview.chromium.org/1153373003/diff/140001/src/factory.h#newcode355 src/factory.h:355: Handle<Float32x4> NewFloat32x4(double w, double x, double y, double z, ...
5 years, 6 months ago (2015-06-03 13:27:15 UTC) #9
bbudge
PTAL https://codereview.chromium.org/1153373003/diff/140001/src/factory.h File src/factory.h (right): https://codereview.chromium.org/1153373003/diff/140001/src/factory.h#newcode355 src/factory.h:355: Handle<Float32x4> NewFloat32x4(double w, double x, double y, double ...
5 years, 6 months ago (2015-06-03 20:31:49 UTC) #10
titzer
LGTM with one last comment on test. https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc#newcode248 test/cctest/test-heap.cc:248: CHECK(std::isnan(float32x4->get_lane(2))); Can ...
5 years, 6 months ago (2015-06-03 20:34:41 UTC) #11
bbudge
https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc#newcode248 test/cctest/test-heap.cc:248: CHECK(std::isnan(float32x4->get_lane(2))); On 2015/06/03 20:34:40, titzer wrote: > Can we ...
5 years, 6 months ago (2015-06-03 21:32:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153373003/220001
5 years, 6 months ago (2015-06-03 23:54:47 UTC) #15
commit-bot: I haz the power
Committed patchset #10 (id:220001)
5 years, 6 months ago (2015-06-03 23:56:27 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 23:56:47 UTC) #17
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/f9dd3446da82fbbf20c344ceb6a87be2c11f5759
Cr-Commit-Position: refs/heads/master@{#28797}

Powered by Google App Engine
This is Rietveld 408576698