Add new Float32x4 type for SIMD.js.

test/cctest/test-heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 41 matching lines @@
   CHECK_EQ(type, map->instance_type());
   CHECK_EQ(instance_size, map->instance_size());
 }
 
 
 TEST(HeapMaps) {
   CcTest::InitializeVM();
   Heap* heap = CcTest::heap();
   CheckMap(heap->meta_map(), MAP_TYPE, Map::kSize);
   CheckMap(heap->heap_number_map(), HEAP_NUMBER_TYPE, HeapNumber::kSize);
+  CheckMap(heap->float32x4_map(), FLOAT32X4_TYPE, Float32x4::kSize);
   CheckMap(heap->fixed_array_map(), FIXED_ARRAY_TYPE, kVariableSizeSentinel);
   CheckMap(heap->string_map(), STRING_TYPE, kVariableSizeSentinel);
 }
 
 
 static void CheckOddball(Isolate* isolate, Object* obj, const char* string) {
   CHECK(obj->IsOddball());
   Handle<Object> handle(obj, isolate);
   Object* print_string =
       *Execution::ToString(isolate, handle).ToHandleChecked();
@@ skipping 134 matching lines @@
   CheckSmi(isolate, 42, "42");
   CheckSmi(isolate, -42, "-42");
 
   // Check ToString for Numbers
   CheckNumber(isolate, 1.1, "1.1");
 
   CheckFindCodeObject(isolate);
 }
 
 
+TEST(SimdObjects) {
+  CcTest::InitializeVM();
+  Isolate* isolate = CcTest::i_isolate();
+  Factory* factory = isolate->factory();
+
+  HandleScope sc(isolate);
+
+  Handle<Object> value = factory->NewFloat32x4(1, 2, 3, 4);
+  CHECK(value->IsFloat32x4());
+  CHECK(value->BooleanValue());  // SIMD values map to true.
+  Float32x4* float32x4 = *Handle<Float32x4>::cast(value);
+  CHECK_EQ(1, float32x4->get_lane(0));
+  CHECK_EQ(2, float32x4->get_lane(1));
+  CHECK_EQ(3, float32x4->get_lane(2));
+  CHECK_EQ(4, float32x4->get_lane(3));
+  float32x4->set_lane(3, 5);
+  CHECK_EQ(5, float32x4->get_lane(3));
+
+  // Check ToString for SIMD values.
+  // TODO(bbudge): Switch to Check* style function to test ToString().
+  std::ostringstream os;
+  float32x4->Float32x4Print(os);
+  CHECK_EQ("1, 2, 3, 5", os.str());
+
+  float32x4->set_lane(0, -0.0);
+  CHECK_EQ(-0.0, float32x4->get_lane(0));
+  float quiet_NaN = std::numeric_limits<float>::quiet_NaN();
+  float signaling_NaN = std::numeric_limits<float>::signaling_NaN();
+  float32x4->set_lane(1, quiet_NaN);
+  CHECK(std::isnan(float32x4->get_lane(1)));
+  float32x4->set_lane(2, signaling_NaN);
+  CHECK(std::isnan(float32x4->get_lane(2)));

[titzer, 2015/06/03 20:34:40]

Can we also check that writing to one lane doesn't overwrite the other lanes?

[bbudge, 2015/06/03 21:32:52]

Done. I added a templated function to do the lane tests, since this will be
needed by all types and is regular. I tried to do it without adding anything
weird to the Float32x4 definition.

+}
+
+
 TEST(Tagging) {
   CcTest::InitializeVM();
   int request = 24;
   CHECK_EQ(request, static_cast<int>(OBJECT_POINTER_ALIGN(request)));
   CHECK(Smi::FromInt(42)->IsSmi());
   CHECK(Smi::FromInt(Smi::kMinValue)->IsSmi());
   CHECK(Smi::FromInt(Smi::kMaxValue)->IsSmi());
 }
 
 
@@ skipping 5672 matching lines @@
   size_t counter2 = 2000;
   tracer->SampleAllocation(time2, counter2, counter2);
   size_t throughput = tracer->AllocationThroughputInBytesPerMillisecond(100);
   CHECK_EQ(2 * (counter2 - counter1) / (time2 - time1), throughput);
   int time3 = 1000;
   size_t counter3 = 30000;
   tracer->SampleAllocation(time3, counter3, counter3);
   throughput = tracer->AllocationThroughputInBytesPerMillisecond(100);
   CHECK_EQ(2 * (counter3 - counter1) / (time3 - time1), throughput);
 }