Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1153343007: Fix regression in adb_*_command_line commands caused by c481d677 (Closed)

Created:
5 years, 6 months ago by agrieve
Modified:
5 years, 6 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix regression in adb_*_command_line commands caused by c481d677 The "cut" should run on the host rather than the client. Android M preview includes "cut", so this slipped through :S. BUG=493878 Committed: https://crrev.com/7ce7cf307644d8309740a204689c6642f2153e2b Cr-Commit-Position: refs/heads/master@{#332544}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/adb_command_line_functions.sh View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 9 (2 generated)
agrieve
5 years, 6 months ago (2015-06-03 00:20:28 UTC) #2
jbudorick
https://codereview.chromium.org/1153343007/diff/1/build/android/adb_command_line_functions.sh File build/android/adb_command_line_functions.sh (right): https://codereview.chromium.org/1153343007/diff/1/build/android/adb_command_line_functions.sh#newcode27 build/android/adb_command_line_functions.sh:27: adb shell "cat $CMD_LINE_FILE 2>/dev/null" | cut -d ' ...
5 years, 6 months ago (2015-06-03 00:25:04 UTC) #3
agrieve
https://codereview.chromium.org/1153343007/diff/1/build/android/adb_command_line_functions.sh File build/android/adb_command_line_functions.sh (right): https://codereview.chromium.org/1153343007/diff/1/build/android/adb_command_line_functions.sh#newcode27 build/android/adb_command_line_functions.sh:27: adb shell "cat $CMD_LINE_FILE 2>/dev/null" | cut -d ' ...
5 years, 6 months ago (2015-06-03 01:26:30 UTC) #4
jbudorick
lgtm https://codereview.chromium.org/1153343007/diff/1/build/android/adb_command_line_functions.sh File build/android/adb_command_line_functions.sh (right): https://codereview.chromium.org/1153343007/diff/1/build/android/adb_command_line_functions.sh#newcode27 build/android/adb_command_line_functions.sh:27: adb shell "cat $CMD_LINE_FILE 2>/dev/null" | cut -d ...
5 years, 6 months ago (2015-06-03 02:52:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153343007/1
5 years, 6 months ago (2015-06-03 03:00:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 03:26:27 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 03:27:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ce7cf307644d8309740a204689c6642f2153e2b
Cr-Commit-Position: refs/heads/master@{#332544}

Powered by Google App Engine
This is Rietveld 408576698