build/android/adb_command_line_functions.sh - Issue 1153343007: Fix regression in adb_*_command_line commands caused by c481d677

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/adb_command_line_functions.sh

Issue 1153343007: Fix regression in adb_*_command_line commands caused by c481d677 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/adb_command_line_functions.sh

diff --git a/build/android/adb_command_line_functions.sh b/build/android/adb_command_line_functions.sh

index 8a7700911bcc0c5a2371b9f0e6b964a24ea2a6b2..7ea98b09be67f9a163ed459fda5b12b53241cc48 100755

--- a/build/android/adb_command_line_functions.sh

+++ b/build/android/adb_command_line_functions.sh

@@ -24,7 +24,7 @@ function set_command_line() {

if [ $# -eq 0 ] ; then

# If nothing specified, print the command line (stripping off "chrome ")

- adb shell "cat $CMD_LINE_FILE 2>/dev/null | cut -d ' ' -s -f2-"

+ adb shell "cat $CMD_LINE_FILE 2>/dev/null" | cut -d ' ' -s -f2-

jbudorick 2015/06/03 00:25:03 just want to make sure that -f2- behaves like -f "

agrieve 2015/06/03 01:26:30 It does (I didn't touch the cut command)

jbudorick 2015/06/03 02:52:57 just asking because it was -f "2-" prior to your f

elif [ $# -eq 1 ] && [ "$1" = '' ] ; then

# If given an empty string, delete the command line.

set -x

« no previous file with comments | « no previous file | no next file » | no next file with comments »