Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1153283005: Revert "Revert of Refactor get_salient_image_url.js to use DocumentImageExtractor" (Closed)

Created:
5 years, 6 months ago by Theresa
Modified:
5 years, 6 months ago
CC:
arv+watch_chromium.org, chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Refactor get_salient_image_url.js to use DocumentImageExtractor" This reverts commit 848594a8fd844879fede9f8663d279b1bfac8253. The initial CL was reverted because the Android GN build was failing to compile. GN files have been added. Refactor get_salient_image_url.js to use the DocumentImageExtractor. Move get_salient_image_url.js into components so it accessible for iOS as well. BUG=454623 Committed: https://crrev.com/caf0eb7531ff4e54c74a9d7db47e7ad033d99f44 Cr-Commit-Position: refs/heads/master@{#332203}

Patch Set 1 #

Patch Set 2 : Add chrome_browser_bookmark_android_sources to gn #

Patch Set 3 : Add enhanced_bookmarks_resources.pak for gn #

Patch Set 4 : Add back components/resources/enhanced_bookmarks/BUIlD.gn #

Patch Set 5 : Add back third_party/document_image_extractor/document_image_extractor.gni #

Patch Set 6 : Last upload doesn't appear to have made it all the way #

Patch Set 7 : Tweak chrome/BUILD.gn #

Patch Set 8 : Add //components/resources/enhanced_bookmarks:enhanced_bookmarks_resources as a dep in chrome/brows… #

Patch Set 9 : Add closure_out_dir var to components/resources/enhanced_bookmarks/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -104 lines) Patch
M chrome/BUILD.gn View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/enhanced_bookmarks/android/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h View 3 chunks +23 lines, -4 lines 0 comments Download
M chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc View 5 chunks +41 lines, -20 lines 0 comments Download
M chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/get_salient_image_url.js View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +14 lines, -7 lines 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
A components/resources/enhanced_bookmarks/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +87 lines, -0 lines 0 comments Download
A + components/resources/enhanced_bookmarks/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download
A components/resources/enhanced_bookmarks/dom_initializer.js View 1 chunk +11 lines, -0 lines 0 comments Download
A components/resources/enhanced_bookmarks/enhanced_bookmarks.gypi View 1 chunk +89 lines, -0 lines 0 comments Download
A components/resources/enhanced_bookmarks/enhanced_bookmarks_resources.grd View 1 chunk +15 lines, -0 lines 0 comments Download
A components/resources/enhanced_bookmarks/enhanced_bookmarks_resources.gyp View 1 chunk +31 lines, -0 lines 0 comments Download
A components/resources/enhanced_bookmarks/get_salient_image_url.js View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/document_image_extractor/document_image_extractor.gni View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Theresa
ptal - I'm not sure why the tryjobs didn't throw a fit, but the Android ...
5 years, 6 months ago (2015-05-28 20:01:36 UTC) #1
Theresa
ptal - I'm not sure why the tryjobs didn't throw a fit, but the Android ...
5 years, 6 months ago (2015-05-28 20:13:56 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-05-29 11:21:40 UTC) #4
James Hawkins
On 2015/05/29 11:21:40, jochen wrote: > lgtm LGTM, but please include the reason why this ...
5 years, 6 months ago (2015-05-29 18:45:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153283005/160001
5 years, 6 months ago (2015-06-01 15:03:44 UTC) #7
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 6 months ago (2015-06-01 16:20:04 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 16:23:33 UTC) #9
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/caf0eb7531ff4e54c74a9d7db47e7ad033d99f44
Cr-Commit-Position: refs/heads/master@{#332203}

Powered by Google App Engine
This is Rietveld 408576698