chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc - Issue 1153283005: Revert "Revert of Refactor get_salient_image_url.js to use DocumentImageExtractor"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

Issue 1153283005: Revert "Revert of Refactor get_salient_image_url.js to use DocumentImageExtractor" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add closure_out_dir var to components/resources/enhanced_bookmarks/BUILD.gn Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc ('k') | chrome/browser/resources/get_salient_image_url.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

diff --git a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

index 96c2f5be0a3aab92cb4ec2108c68461af45d2dc8..94a1de125d375445bc6ec1e2c9a9d28023a1c925 100644

--- a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

+++ b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

@@ -115,7 +115,7 @@ void EnhancedBookmarksBridge::FetchImageForTab(JNIEnv* env,

jobject j_web_contents) {

WebContents* web_contents = WebContents::FromJavaWebContents(j_web_contents);

bookmark_image_service_->RetrieveSalientImageFromContext(

- web_contents->GetMainFrame(), web_contents->GetURL(), true);

+ web_contents, web_contents->GetURL(), true);

}

ScopedJavaLocalRef<jstring> EnhancedBookmarksBridge::GetBookmarkDescription(