PlzNavigate: send Javascript urls synchronously to the renderer

content/browser/frame_host/frame_tree_node.cc

Index: content/browser/frame_host/frame_tree_node.cc
diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc
index 08254c9d2d44aafdbfd321f9c38e379bde819bee..208cf8916c885c5ae7e3eb2a17a5dc4c5545b66f 100644
--- a/content/browser/frame_host/frame_tree_node.cc
+++ b/content/browser/frame_host/frame_tree_node.cc
@@ -186,7 +186,9 @@ bool FrameTreeNode::IsLoading() const {
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableBrowserSideNavigation)) {
-    if (navigation_request_)
+    if (navigation_request_ &&
+        !navigation_request_->common_params().url.SchemeIs(
+            url::kJavaScriptScheme))

[nasko, 2015/05/29 14:17:46]

Why not keep it closer to existing functionality? The loading state is
explicitly set in RFH::Navigate -
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/fr....

[clamy, 2015/05/29 16:02:06]

We cannot use a RFH to set the loading state as we don't have one until the
navigation is ready to commit, and we need to be aware we are loading before
that. So we're using the NavigationRequest until the navigation has committed. I
have added a comment as to why this specific case about JavaScript urls is
needed.

[nasko, 2015/06/01 20:38:22]

Do we even create NavigationRequest objects for JS URLs? Purely on code flow, if
there is navigation_request_ for JS URL, we will fall back to
current_frame_host->is_loading(). What happens if we don't have a current host -
new tab that is going to load a JS URL?

[clamy, 2015/06/02 12:28:16]

After further thinking, I removed this part, and now reset the NavigationRequest
in NavigatorImpl::CommitNavigation, since we are not expecting a commit from a
Javascript URL. This seems better and solve the loading state issue if the
Javascript URL triggers a new navigation.

       return true;
   } else {
     if (pending_frame_host && pending_frame_host->is_loading())