content/browser/frame_host/navigation_request.cc - Issue 1153193011: PlzNavigate: send Javascript urls synchronously to the renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1153193011: PlzNavigate: send Javascript urls synchronously to the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/frame_tree_node.cc ('K') | « content/browser/frame_host/frame_tree_node.cc ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_request.cc

diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc

index 1c0a87ef65e701d2af93bdf613b623ab39c29d61..e998d178868a98759007ef6fd0b4ffd800d1c450 100644

--- a/content/browser/frame_host/navigation_request.cc

+++ b/content/browser/frame_host/navigation_request.cc

@@ -52,9 +52,10 @@ int LoadFlagFromNavigationType(FrameMsg_Navigate_Type::Value navigation_type) {

// static

bool NavigationRequest::ShouldMakeNetworkRequest(const GURL& url) {

- // Data urls should not make network requests.

+ // Data and Javascript urls should not make network requests.

// TODO(clamy): same document navigations should not make network requests.

- return !url.SchemeIs(url::kDataScheme) && url != GURL(url::kAboutBlankURL);

+ return !url.SchemeIs(url::kDataScheme) && url != GURL(url::kAboutBlankURL) &&

+ !url.SchemeIs(url::kJavaScriptScheme);

}

// static