Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1153153003: Revert of Use --icf=all instead of --icf=safe (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use --icf=all instead of --icf=safe (patchset #2 id:20001 of https://codereview.chromium.org/1153143004/) Reason for revert: Speculative, to see if it's related to http://crbug.com/492809 Original issue's description: > Use --icf=all instead of --icf=safe > > With --icf=safe, functions whose address is taken aren't folded. > Folding could change the results of function pointer comparisons. > > However, on x86_64 with pie, --icf=safe disables almost all folding, > for technical reasons. Since using --icf=all will save 7 MB on x86_64 > and all tests seem to pass with it, switch to --icf=all. If we end up > having a function where we absolutely need equality, we can pass > --keep-unique,<symbol-name> for that symbol. > > And if this turns out to be some maintenance burden, we can switch > back to --icf=safe. > > Change the flag on all platforms where we use gold, not just x86_64, for > consistency so that if we end up having problems with this, we notice > it faster. > > BUG=76280, 492177 > > Committed: https://crrev.com/45ab39af3cc293e150158bf06515a47319db9f79 > Cr-Commit-Position: refs/heads/master@{#331474} TBR=thestig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=76280, 492177 Committed: https://crrev.com/9720ab26977ea35252c9ba2e5111c4af63404c22 Cr-Commit-Position: refs/heads/master@{#331724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of Use --icf=all instead of --icf=safe
5 years, 7 months ago (2015-05-28 02:24:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153153003/1
5 years, 7 months ago (2015-05-28 02:25:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-28 02:26:44 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9720ab26977ea35252c9ba2e5111c4af63404c22 Cr-Commit-Position: refs/heads/master@{#331724}
5 years, 7 months ago (2015-05-28 02:27:30 UTC) #4
Lei Zhang
5 years, 7 months ago (2015-05-28 05:55:21 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698