Issue 1153053012: Make our raw/ tests actually check the paint output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153053012: Make our raw/ tests actually check the paint output. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make our raw/ tests actually check the paint output. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b7f173c1917e711d67e37beb532f5935429f8963

Patch Set 2 : use hex for the colours in the test output #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -4 lines)			Patch
M	sky/tests/raw/render_box.dart	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	sky/tests/raw/render_box-expected.txt	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	sky/tests/raw/render_flex.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/tests/raw/render_flex-expected.txt	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
A	sky/tests/resources/display_list.dart	View	1	1 chunk	+145 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1153053012/diff/1/sky/tests/raw/render_box-expected.txt File sky/tests/raw/render_box-expected.txt (right): https://codereview.chromium.org/1153053012/diff/1/sky/tests/raw/render_box-expected.txt#newcode8 sky/tests/raw/render_box-expected.txt:8: 1 | | drawRect(0.0:0.0:600.0:800.0, Paint(4278255360)) Can we print ...

5 years, 6 months ago (2015-05-29 00:32:29 UTC) #2

Hixie

5 years, 6 months ago (2015-05-29 00:36:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b7f173c1917e711d67e37beb532f5935429f8963 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1153053012: Make our raw/ tests actually check the paint output. (Closed)

Description

Patch Set 1 #

Patch Set 2 : use hex for the colours in the test output #

Messages