net/socket/mock_client_socket_pool_manager.h - Issue 1153003002: Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/mock_client_socket_pool_manager.h

Issue 1153003002: Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated CL as directed. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/mock_client_socket_pool_manager.h

diff --git a/net/socket/mock_client_socket_pool_manager.h b/net/socket/mock_client_socket_pool_manager.h

index 76d7704316a31cfd9ce815143ab58c6ff9ef9ef1..80327665cc6256730b62503ffd0a18145296dcf3 100644

--- a/net/socket/mock_client_socket_pool_manager.h

+++ b/net/socket/mock_client_socket_pool_manager.h

@@ -37,7 +37,7 @@ class MockClientSocketPoolManager : public ClientSocketPoolManager {

const HostPortPair& http_proxy) override;

SSLClientSocketPool* GetSocketPoolForSSLWithProxy(

const HostPortPair& proxy_server) override;

- base::Value* SocketPoolInfoToValue() const override;

+ scoped_ptr<base::Value> SocketPoolInfoToValue() const override;

private:

typedef internal::OwnedPoolMap<HostPortPair, TransportClientSocketPool*>

« no previous file with comments | « net/socket/client_socket_pool_manager_impl.cc ('k') | net/socket/mock_client_socket_pool_manager.cc » ('j') | no next file with comments »