Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: net/socket/mock_client_socket_pool_manager.cc

Issue 1153003002: Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CL Updated Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/mock_client_socket_pool_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/mock_client_socket_pool_manager.cc
diff --git a/net/socket/mock_client_socket_pool_manager.cc b/net/socket/mock_client_socket_pool_manager.cc
index 0496adb9636b7d46b54feae78a44dd595df42903..632e20a7e351f61907e6bb8337d9c732d12aad08 100644
--- a/net/socket/mock_client_socket_pool_manager.cc
+++ b/net/socket/mock_client_socket_pool_manager.cc
@@ -4,6 +4,7 @@
#include "net/socket/mock_client_socket_pool_manager.h"
+#include "base/values.h"
#include "net/http/http_proxy_client_socket_pool.h"
#include "net/socket/socks_client_socket_pool.h"
#include "net/socket/ssl_client_socket_pool.h"
@@ -86,9 +87,11 @@ SSLClientSocketPool* MockClientSocketPoolManager::GetSocketPoolForSSLWithProxy(
return NULL;
}
-base::Value* MockClientSocketPoolManager::SocketPoolInfoToValue() const {
+scoped_ptr<base::Value> MockClientSocketPoolManager::SocketPoolInfoToValue()
+ const {
+ scoped_ptr<base::ListValue> list(new base::ListValue());
eroman 2015/05/26 17:46:51 This is not equivalent. Before it was returning NU
NOTIMPLEMENTED();
- return NULL;
+ return list.Pass();
}
} // namespace net
« no previous file with comments | « net/socket/mock_client_socket_pool_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698