Remove some duplicated code when accounting for floats at line-end

Remove some duplicated code when accounting for floats at line-end

This results in less code, but not that much less. The real win is in moving the
quite cumbersome logic to a place where it's not obscuring the purpose of the
functions it lives in.

BUG=487775
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196012

[rhogan, 2015-05-27 18:15:30]

robhogan@gmail.com changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-05-27 18:26:19]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-05-27 18:26:19]

lgtm

Looks better to me.

https://codereview.chromium.org/1152953002/diff/1/Source/core/layout/LayoutBl...
File Source/core/layout/LayoutBlockFlowLine.cpp (left):

https://codereview.chromium.org/1152953002/diff/1/Source/core/layout/LayoutBl...
Source/core/layout/LayoutBlockFlowLine.cpp:1032: // include the padding
incorrectly. -dwh
Ahhh, from the good ol' days of "-dwh"

[commit-bot: I haz the power, 2015-05-27 18:26:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1152953002/1

[commit-bot: I haz the power, 2015-05-27 18:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-27 18:38:13]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[rhogan, 2015-05-27 20:55:13]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2015-05-27 20:55:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1152953002/1

[commit-bot: I haz the power, 2015-05-27 22:18:40]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196012

[rhogan, 2015-06-10 18:25:26]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1174053003/ by robhogan@gmail.com.

The reason for reverting is: Together with
https://codereview.chromium.org/1132103007 caused issues with layout identified
in crbug.com/498664. Reverting both patches..