Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1152953002: Remove some duplicated code when accounting for floats at line-end (Closed)

Created:
5 years, 7 months ago by rhogan
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove some duplicated code when accounting for floats at line-end This results in less code, but not that much less. The real win is in moving the quite cumbersome logic to a place where it's not obscuring the purpose of the functions it lives in. BUG=487775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196012

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -42 lines) Patch
M Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 3 chunks +35 lines, -42 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
rhogan
5 years, 7 months ago (2015-05-27 18:15:31 UTC) #2
leviw_travelin_and_unemployed
lgtm Looks better to me. https://codereview.chromium.org/1152953002/diff/1/Source/core/layout/LayoutBlockFlowLine.cpp File Source/core/layout/LayoutBlockFlowLine.cpp (left): https://codereview.chromium.org/1152953002/diff/1/Source/core/layout/LayoutBlockFlowLine.cpp#oldcode1032 Source/core/layout/LayoutBlockFlowLine.cpp:1032: // include the padding ...
5 years, 7 months ago (2015-05-27 18:26:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152953002/1
5 years, 7 months ago (2015-05-27 18:26:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/36516)
5 years, 7 months ago (2015-05-27 18:38:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152953002/1
5 years, 7 months ago (2015-05-27 20:55:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196012
5 years, 7 months ago (2015-05-27 22:18:40 UTC) #10
rhogan
5 years, 6 months ago (2015-06-10 18:25:26 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1174053003/ by robhogan@gmail.com.

The reason for reverting is: Together with
https://codereview.chromium.org/1132103007 caused issues with layout identified
in crbug.com/498664. Reverting both patches..

Powered by Google App Engine
This is Rietveld 408576698