Source/core/layout/LayoutBlockFlow.h - Issue 1152953002: Remove some duplicated code when accounting for floats at line-end

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlockFlow.h

Issue 1152953002: Remove some duplicated code when accounting for floats at line-end (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBlockFlow.h

diff --git a/Source/core/layout/LayoutBlockFlow.h b/Source/core/layout/LayoutBlockFlow.h

index ce34fe172b2d5606c488949d810b6cb35fa94bdd..9be0dfff44c3b2396ac06ef02eb1689b7e47d45b 100644

--- a/Source/core/layout/LayoutBlockFlow.h

+++ b/Source/core/layout/LayoutBlockFlow.h

@@ -523,6 +523,7 @@ private:

void layoutRunsAndFloatsInRange(LineLayoutState&, InlineBidiResolver&,

const InlineIterator& cleanLineStart, const BidiStatus& cleanLineBidiStatus);

void linkToEndLineIfNeeded(LineLayoutState&);

+ bool appendFloatsToEndOfLine(LineLayoutState&, bool updateFloatIndex);

static void markDirtyFloatsForPaintInvalidation(Vector<FloatWithRect>& floats);

void checkFloatsInCleanLine(RootInlineBox*, Vector<FloatWithRect>&, size_t& floatIndex, bool& encounteredNewFloat, bool& dirtiedByFloat);

RootInlineBox* determineStartPosition(LineLayoutState&, InlineBidiResolver&);