Preserve bookmark favicons when clearing all browsing data

Preserve bookmark favicons when clearing all browsing data

This CL makes HistoryBackend::DeleteAllHistory() preserve bookmark favicons in
the special case that the bookmark page URL is not in the URL table in the
history database. Calling HistoryService::DeleteURL() (e.g. as a result of
pressing Shift+Delete in the omnibox) makes this special case happen.

BUG=478944
TEST=HistoryBackendTest.DeleteAllURLPreviouslyDeleted

Committed: https://crrev.com/76e0fe6c1e1f837b09f2d44233c2a3bcd914cea8
Cr-Commit-Position: refs/heads/master@{#332389}

[pkotwicz, 2015-05-31 20:42:40]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2015-05-31 20:45:05]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2015-05-31 20:47:02]

pkotwicz@chromium.org changed reviewers:
+ sky@chromium.org

[pkotwicz, 2015-05-31 20:47:03]

Scott, can you please take a look?

Please see the bug for a discussion of whether this change is the right behavior

[pkotwicz, 2015-05-31 20:49:18]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2015-05-31 20:53:41]

Patchset #1 (id:60001) has been deleted

[sky, 2015-06-01 15:15:31]

LGTM

https://codereview.chromium.org/1152933003/diff/70001/components/history/core...
File components/history/core/browser/history_backend.cc (right):

https://codereview.chromium.org/1152933003/diff/70001/components/history/core...
components/history/core/browser/history_backend.cc:2541: GURL url =
url_and_title.url;
const GURL&

[pkotwicz, 2015-06-02 14:26:44]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-06-02 14:26:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1152933003/#ps90001
(title: " ")

[commit-bot: I haz the power, 2015-06-02 14:27:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1152933003/90001

[commit-bot: I haz the power, 2015-06-02 15:17:49]

Committed patchset #2 (id:90001)

[commit-bot: I haz the power, 2015-06-02 15:18:31]

Patchset 2 (id:??) landed as
https://crrev.com/76e0fe6c1e1f837b09f2d44233c2a3bcd914cea8
Cr-Commit-Position: refs/heads/master@{#332389}