Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: components/history/core/browser/history_backend.h

Issue 1152933003: Preserve bookmark favicons when clearing all browsing data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_backend.h
diff --git a/components/history/core/browser/history_backend.h b/components/history/core/browser/history_backend.h
index fcc2b53a16b5df8466cdfc61fc7c70b42a450097..c1148cff69c55eaa9ecdbaf2b0aaa0facbe90387 100644
--- a/components/history/core/browser/history_backend.h
+++ b/components/history/core/browser/history_backend.h
@@ -456,6 +456,7 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
friend class HistoryBackendDBBaseTest; // So the unit tests can poke our
// innards.
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, DeleteAll);
+ FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, DeleteAllURLPreviouslyDeleted);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, DeleteAllThenAddData);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddPagesWithDetails);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, UpdateURLs);
@@ -728,7 +729,7 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// Given a vector of all URLs that we will keep, removes all thumbnails
// referenced by any URL, and also all favicons that aren't used by those
// URLs.
- bool ClearAllThumbnailHistory(const URLRows& kept_urls);
+ bool ClearAllThumbnailHistory(const std::vector<GURL>& kept_urls);
// Deletes all information in the history database, except for the supplied
// set of URLs in the URL table (these should correspond to the bookmarked
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698