Enable Dart's checked mode in the Sky controller by default for debug builds

Enable Dart's checked mode in the Sky controller by default for debug builds

This matches the behaviour of the Mojo Dart controller and was requested by tonyg@

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/2f116f02bffbc1373c232d8e17d6116fdba496f6

[Cutch, 2015-06-03 16:03:04]

johnmccutchan@google.com changed reviewers:
+ abarth@chromium.org, eseidel@chromium.org

[abarth-chromium, 2015-06-03 16:17:37]

lgtm

[abarth-chromium, 2015-06-03 16:18:17]

Isn't this the same as what it was doing already?

[Cutch, 2015-06-03 16:33:12]

On 2015/06/03 16:18:17, abarth wrote:
> Isn't this the same as what it was doing already?

No, a user would have to specify sky_assert_always_on from the command line to
enable this.

This change decouples Dart's checked mode from Sky's native code asserts and
enables Dart's checked mode by default for debug builds.

[Cutch, 2015-06-03 16:33:23]

Committed patchset #2 (id:20001) manually as
2f116f02bffbc1373c232d8e17d6116fdba496f6 (presubmit successful).

[abarth-chromium, 2015-06-03 16:59:38]

On 2015/06/03 at 16:33:12, johnmccutchan wrote:
> No, a user would have to specify sky_assert_always_on from the command line to
enable this.
> 
> This change decouples Dart's checked mode from Sky's native code asserts and
enables Dart's checked mode by default for debug builds.

ENABLE(ASSERT) was already on-by-default for debug builds.  In any case, having
a separate flag makes sense.