Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 1152873006: Enable Dart's checked mode in the Sky controller by default for debug builds (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Enable Dart's checked mode in the Sky controller by default for debug builds This matches the behaviour of the Mojo Dart controller and was requested by tonyg@ R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2f116f02bffbc1373c232d8e17d6116fdba496f6

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M sky/engine/config.gni View 2 chunks +11 lines, -0 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Cutch
5 years, 6 months ago (2015-06-03 16:03:49 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-03 16:17:37 UTC) #3
abarth-chromium
Isn't this the same as what it was doing already?
5 years, 6 months ago (2015-06-03 16:18:17 UTC) #4
Cutch
On 2015/06/03 16:18:17, abarth wrote: > Isn't this the same as what it was doing ...
5 years, 6 months ago (2015-06-03 16:33:12 UTC) #5
Cutch
Committed patchset #2 (id:20001) manually as 2f116f02bffbc1373c232d8e17d6116fdba496f6 (presubmit successful).
5 years, 6 months ago (2015-06-03 16:33:23 UTC) #6
abarth-chromium
5 years, 6 months ago (2015-06-03 16:59:38 UTC) #7
Message was sent while issue was closed.
On 2015/06/03 at 16:33:12, johnmccutchan wrote:
> No, a user would have to specify sky_assert_always_on from the command line to
enable this.
> 
> This change decouples Dart's checked mode from Sky's native code asserts and
enables Dart's checked mode by default for debug builds.

ENABLE(ASSERT) was already on-by-default for debug builds.  In any case, having
a separate flag makes sense.

Powered by Google App Engine
This is Rietveld 408576698