sky/engine/core/script/dart_controller.cc - Issue 1152873006: Enable Dart's checked mode in the Sky controller by default for debug builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/script/dart_controller.cc

Issue 1152873006: Enable Dart's checked mode in the Sky controller by default for debug builds (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/script/dart_controller.cc

diff --git a/sky/engine/core/script/dart_controller.cc b/sky/engine/core/script/dart_controller.cc

index 039e36ac3539860805be5087c7f34c012028af3e..4b041a046515aa62d6cd85ad5ba3ff0ac947e6ba 100644

--- a/sky/engine/core/script/dart_controller.cc

+++ b/sky/engine/core/script/dart_controller.cc

@@ -41,7 +41,7 @@

namespace blink {

-#if ENABLE(ASSERT)

+#if ENABLE(DART_STRICT)

static const char* kCheckedModeArgs[] = {

"--enable_asserts",

"--enable_type_checks",

@@ -369,7 +369,7 @@ void DartController::InitVM() {

int argc = 0;

const char** argv = nullptr;

-#if ENABLE(ASSERT)

+#if ENABLE(DART_STRICT)

argc = arraysize(kCheckedModeArgs);

argv = kCheckedModeArgs;

#endif

« no previous file with comments | « sky/engine/config.gni ('k') | no next file » | no next file with comments »