Re-land Crankshaft-generated KeyedLoad stubs.

src/arm/macro-assembler-arm.h

Index: src/arm/macro-assembler-arm.h
diff --git a/src/arm/macro-assembler-arm.h b/src/arm/macro-assembler-arm.h
index 5321a0d81ef40a8aed33f67aebbc3fb5b1878c72..4dd7b7f6367899ce855126d638b42d3bbca78ae4 100644
--- a/src/arm/macro-assembler-arm.h
+++ b/src/arm/macro-assembler-arm.h
@@ -107,6 +107,10 @@ enum TargetAddressStorageMode {
   NEVER_INLINE_TARGET_ADDRESS
 };
 
+
+void IterateCompiledFrame(const StandardFrame* frame, ObjectVisitor* v);

[Sven Panne, 2012/12/11 07:59:06]

Shouldn't this be a method of StandardFrame? A naked top-level function always
looks a bit suspicious in an OO world...

Same for other platforms.

[Jakob Kummerow, 2012/12/11 14:05:54]

Well, the name "IterateCompiledFrame" expresses the notion that this is how you
iterate over a compiled frame, not over a StandardFrame, so renaming this to
StandardFrame::Iterate would not be appropriate (e.g. because we have
InternalFrame which also is-a StandardFrame but iterates differently). I'm not
opposed to moving it into the class without renaming it (i.e. calling it
StandardFrame::IterateCompiledFrame), but I don't feel strongly about it.

[Sven Panne, 2012/12/11 14:19:27]

Well, that argument holds for the original signature as well: Using
StandardFrame is basically lying. :-) There seems to be something fishy in our
class hierarchy here, but I can live with a member function having a
warning-like name. Nevertheless, this is not solving the root of the problem...

[danno, 2012/12/11 14:26:49]

There's not thing fishy about our class hierarchy. Stub frames are both
CompiledFrames and StandardsFrames. OptimizedFrames are CompiledFrames and
JavaScriptFrames. C++ makes expressing this painful, and the multiple
inheritance ban means that it will always look funny.

I have nothing against putting this method in StandardFrame with the "Compiled"
name, I'll do that.
On 2012/12/11 14:19:27, Sven Panne wrote:

+
+
 // MacroAssembler implements a collection of frequently used macros.
 class MacroAssembler: public Assembler {
  public:
@@ -1375,7 +1379,8 @@ class MacroAssembler: public Assembler {
 
   // Needs access to SafepointRegisterStackIndex for compiled frame
   // traversal.
-  friend class CompiledFrame;
+  friend void IterateCompiledFrame(const StandardFrame* frame,
+                                   ObjectVisitor* v);
 };