Re-land Crankshaft-generated KeyedLoad stubs.

src/arm/macro-assembler-arm.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 89 matching lines @@
                 Register reg5 = no_reg,
                 Register reg6 = no_reg);
 #endif
 
 
 enum TargetAddressStorageMode {
   CAN_INLINE_TARGET_ADDRESS,
   NEVER_INLINE_TARGET_ADDRESS
 };
 
+
+void IterateCompiledFrame(const StandardFrame* frame, ObjectVisitor* v);

[Sven Panne, 2012/12/11 07:59:06]

Shouldn't this be a method of StandardFrame? A naked top-level function always
looks a bit suspicious in an OO world...

Same for other platforms.

[Jakob Kummerow, 2012/12/11 14:05:54]

Well, the name "IterateCompiledFrame" expresses the notion that this is how you
iterate over a compiled frame, not over a StandardFrame, so renaming this to
StandardFrame::Iterate would not be appropriate (e.g. because we have
InternalFrame which also is-a StandardFrame but iterates differently). I'm not
opposed to moving it into the class without renaming it (i.e. calling it
StandardFrame::IterateCompiledFrame), but I don't feel strongly about it.

[Sven Panne, 2012/12/11 14:19:27]

Well, that argument holds for the original signature as well: Using
StandardFrame is basically lying. :-) There seems to be something fishy in our
class hierarchy here, but I can live with a member function having a
warning-like name. Nevertheless, this is not solving the root of the problem...

[danno, 2012/12/11 14:26:49]

There's not thing fishy about our class hierarchy. Stub frames are both
CompiledFrames and StandardsFrames. OptimizedFrames are CompiledFrames and
JavaScriptFrames. C++ makes expressing this painful, and the multiple
inheritance ban means that it will always look funny.

I have nothing against putting this method in StandardFrame with the "Compiled"
name, I'll do that.
On 2012/12/11 14:19:27, Sven Panne wrote:

+
+
 // MacroAssembler implements a collection of frequently used macros.
 class MacroAssembler: public Assembler {
  public:
   // The isolate parameter can be NULL if the macro assembler should
   // not use isolate-dependent functionality. In this case, it's the
   // responsibility of the caller to never invoke such function on the
   // macro assembler.
   MacroAssembler(Isolate* isolate, void* buffer, int size);
 
   // Jump, Call, and Ret pseudo instructions implementing inter-working.
@@ skipping 1248 matching lines @@
   MemOperand SafepointRegistersAndDoublesSlot(Register reg);
 
   bool generating_stub_;
   bool allow_stub_calls_;
   bool has_frame_;
   // This handle will be patched with the code object on installation.
   Handle<Object> code_object_;
 
   // Needs access to SafepointRegisterStackIndex for compiled frame
   // traversal.
-  friend class CompiledFrame;
+  friend void IterateCompiledFrame(const StandardFrame* frame,
+                                   ObjectVisitor* v);
 };
 
 
 // The code patcher is used to patch (typically) small parts of code e.g. for
 // debugging and other types of instrumentation. When using the code patcher
 // the exact number of bytes specified must be emitted. It is not legal to emit
 // relocation information. If any of these constraints are violated it causes
 // an assertion to fail.
 class CodePatcher {
  public:
@@ skipping 40 matching lines @@
 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__)
 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
 #else
 #define ACCESS_MASM(masm) masm->
 #endif
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_ARM_MACRO_ASSEMBLER_ARM_H_