Issue 1152693005: Merge to XFA: Move fx_safe_types.h to include/ directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1152693005: Merge to XFA: Move fx_safe_types.h to include/ directory. (Closed)

Created:
5 years, 6 months ago by Tom Sepez

Modified:
5 years, 6 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Move fx_safe_types.h to include/ directory. Original Review URL: https://codereview.chromium.org/1147353006 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6675a80c6afe3652b7bd918b80a16a8effb51b8f

Patch Set 1 #

Patch Set 2 : Fix BUILD.gn #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -48 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	core/include/fxcrt/fx_safe_types.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	core/src/fdrm/crypto/fx_crypt.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	core/src/fpdfdoc/doc_link.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_jpeg.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_Image.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	core/src/fxcrt/extension.h	View		1 chunk	+1 line, -1 line	0 comments	Download
D	core/src/fxcrt/fx_safe_types.h	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View		2 chunks	+2 lines, -1 line	1 comment	Download
M	fpdfsdk/src/pdfwindow/PWL_Edit.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	pdfium.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Committed patchset #2 (id:20001) manually as 6675a80c6afe3652b7bd918b80a16a8effb51b8f (presubmit successful).

5 years, 6 months ago (2015-06-05 02:05:26 UTC) #2

Lei Zhang

5 years, 6 months ago (2015-06-05 02:34:57 UTC) #3

Message was sent while issue was closed.

lgtm, but...

https://codereview.chromium.org/1152693005/diff/20001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1152693005/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:15: #include
"../../../core/include/fxcrt/fx_safe_types.h"
Not sure why you didn't sort this file.

Expand Messages | Collapse Messages