Issue 1147353006: Move fx_safe_types.h to include/ directory.

Issue 1147353006: Move fx_safe_types.h to include/ directory. (Closed)

Created:
5 years, 6 months ago by Tom Sepez

Modified:
5 years, 6 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Move fx_safe_types.h to include/ directory. Small bit of OCD here, since this file is included cross-library (i.e. from fpdfsk), it can't be in src/. In other words, the following should be empty: grep -R 'include.*core/src/' fpdfsdk Fix some IWYU in it at the same time. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/738ca226d4093e9e422b48e9bb460bb65076f973

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -53 lines)			Patch
M	BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	core/include/fxcrt/fx_safe_types.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	core/src/fdrm/crypto/fx_crypt.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	core/src/fpdfdoc/doc_link.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_jpeg.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_Image.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	core/src/fxcrt/extension.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	core/src/fxcrt/fx_safe_types.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/pdfwindow/PWL_Edit.cpp	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 6 months ago (2015-06-05 01:53:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
738ca226d4093e9e422b48e9bb460bb65076f973 (presubmit successful).