Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1152693002: ui: Add sub region copy support to GLImage::CopyTexImage. (Closed)

Created:
5 years, 7 months ago by reveman
Modified:
5 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Add sub region copy support to GLImage::CopyTexImage. This extends the GLImage API with support for partial copy operations. GLImage::CopyTexImage gets two new parameters, |offset| and |rect|. The name of the function is also changed to GLImage::CopyTexSubImage to reflect the new behavior. GLImageMemory implementation is updated to optimize copy operations that span full rows of pixels. BUG=490889 TEST=gpu_unittests, gl_tests Committed: https://crrev.com/6b683f23b25fa464663b9c44f032eca0195ef4bc Cr-Commit-Position: refs/heads/master@{#331051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -36 lines) Patch
M content/common/gpu/stream_texture_android.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/gpu/stream_texture_android.cc View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/stream_texture_manager_in_process_android.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/gl/gl_image.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/gl/gl_image_egl.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_egl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_glx.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_glx.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_memory.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_memory.cc View 1 chunk +23 lines, -12 lines 0 comments Download
M ui/gl/gl_image_stub.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_stub.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/gl/gl_image_surface_texture.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_surface_texture.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
5 years, 7 months ago (2015-05-22 00:39:24 UTC) #2
piman
lgtm
5 years, 7 months ago (2015-05-22 01:15:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152693002/1
5 years, 7 months ago (2015-05-22 01:26:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 02:38:49 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 02:39:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b683f23b25fa464663b9c44f032eca0195ef4bc
Cr-Commit-Position: refs/heads/master@{#331051}

Powered by Google App Engine
This is Rietveld 408576698