Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 1152623005: another double square (Closed)

Created:
5 years, 6 months ago by caryclark
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

another double square This is also a case where the square term is passed to a helper function that squares the error term a second time. R=reed@google.com BUG=skia:3877 Committed: https://skia.googlesource.com/skia/+/c00e1dd93d2c0e3ce6c76c38ccb75de5ddb9663c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/core/SkStroke.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152623005/1
5 years, 6 months ago (2015-06-01 16:09:12 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-01 16:09:13 UTC) #3
reed1
lgtm
5 years, 6 months ago (2015-06-01 17:19:06 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 17:21:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c00e1dd93d2c0e3ce6c76c38ccb75de5ddb9663c

Powered by Google App Engine
This is Rietveld 408576698