Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1152623003: Revert of [Reland] Setup LayoutMenuList to not modify layout tree outside style recalc. (Closed)

Created:
5 years, 7 months ago by tkent
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [Reland] Setup LayoutMenuList to not modify layout tree outside style recalc. (patchset #1 id:1 of https://codereview.chromium.org/1150303003/) Reason for revert: Broke the following tests on Mac: AutomationApiTest.Mixins BrowserTest.CancelBeforeUnloadResetsURL NaClBrowserTestPnacl.PnaclExceptionHandlingDisabled PasswordManagerBrowserTest.NoPromptForFailedLoginFromSubFrameWithMultiFramesInPage Original issue's description: > [Reland] Setup LayoutMenuList to not modify layout tree outside style recalc. > > This CL updates the LayoutMenuList code to not modify the layout > tree ourside of style recalc. The way this is done is, instead of creating > and destroying LayoutText or LayoutBR elements it just uses > LayoutText elements and sets the blank string into them when > it would have used LayoutBR previously. > > This CL was originally landed in r195671 but was reverted in r195695 due to > breaking Android accessiblity tests during the blink roll. The two broken tests > were: > * DumpAccessibilityTreeTest.AccessibilityOptgroup > * DumpAccessibilityTreeTest.AccessibilitySelect > > Those tests have been marked as skip, needs rebaseline in > https://crrev.com/20d41b01d06a8420829a9406eaee773e11239c78 > so this should be safe to reland. > > BUG=370462 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195803 TBR=jchaffraix@chromium.org,leviw@chromium.org,eae@chromium.org,dsinclair@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=370462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195836

Patch Set 1 #

Patch Set 2 : Add rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -276 lines) Patch
D LayoutTests/platform/android/virtual/slimmingpaint/fast/forms/select-baseline-expected.txt View 1 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/platform/android/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/android/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/HTMLOptionElement_label06-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/HTMLOptionElement_label07-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/form-element-geometry-expected.txt View 1 3 chunks +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/menulist-separator-painting-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/select-baseline-expected.txt View 1 2 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/select-empty-option-height-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/selectlist-minsize-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/replaced/three-selects-break-expected.txt View 1 1 chunk +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label06-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label07-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/form-element-geometry-expected.txt View 1 3 chunks +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/menulist-separator-painting-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/select-baseline-expected.txt View 1 2 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/select-empty-option-height-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt View 1 1 chunk +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label06-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label07-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt View 1 3 chunks +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/menulist-separator-painting-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/select-baseline-expected.txt View 1 2 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/select-empty-option-height-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/selectlist-minsize-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/replaced/three-selects-break-expected.txt View 1 1 chunk +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label06-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label07-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/form-element-geometry-expected.txt View 1 3 chunks +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/menulist-separator-painting-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/select-baseline-expected.txt View 1 2 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/select-empty-option-height-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt View 1 1 chunk +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/HTMLOptionElement_label06-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/HTMLOptionElement_label07-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/form-element-geometry-expected.txt View 1 3 chunks +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/select-baseline-expected.txt View 1 2 chunks +2 lines, -4 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/forms/menulist-separator-painting-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/forms/select-empty-option-height-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/HTMLOptionElement_label06-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/HTMLOptionElement_label07-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/form-element-geometry-expected.txt View 1 3 chunks +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/menulist-separator-painting-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/select-baseline-expected.txt View 1 2 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/select-empty-option-height-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/selectlist-minsize-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/replaced/three-selects-break-expected.txt View 1 1 chunk +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label06-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label07-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/form-element-geometry-expected.txt View 1 3 chunks +3 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/menulist-separator-painting-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/select-baseline-expected.txt View 1 2 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/select-empty-option-height-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt View 1 1 chunk +3 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutMenuList.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutMenuList.cpp View 1 8 chunks +39 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Created Revert of [Reland] Setup LayoutMenuList to not modify layout tree outside style recalc.
5 years, 7 months ago (2015-05-25 00:59:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152623003/1
5 years, 7 months ago (2015-05-25 00:59:20 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 7 months ago (2015-05-25 00:59:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152623003/90001
5 years, 7 months ago (2015-05-25 01:20:55 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 01:22:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:90001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195836

Powered by Google App Engine
This is Rietveld 408576698