Source/core/layout/LayoutMenuList.h - Issue 1152623003: Revert of [Reland] Setup LayoutMenuList to not modify layout tree outside style recalc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutMenuList.h

Issue 1152623003: Revert of [Reland] Setup LayoutMenuList to not modify layout tree outside style recalc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add rebaseline Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/win/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt ('k') | Source/core/layout/LayoutMenuList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutMenuList.h

diff --git a/Source/core/layout/LayoutMenuList.h b/Source/core/layout/LayoutMenuList.h

index c8188fb4cf630f579ea05fb55faacfa8a10a5f90..56a1eefcff8dc32d5d83d616d6fc352446ab9517 100644

--- a/Source/core/layout/LayoutMenuList.h

+++ b/Source/core/layout/LayoutMenuList.h

@@ -128,10 +128,7 @@ private:

LayoutText* m_buttonText;

LayoutBlock* m_innerBlock;

- bool m_optionsChanged : 1;

- bool m_isEmpty : 1;

- bool m_hasUpdatedActiveOption : 1;

- bool m_popupIsVisible : 1;

+ bool m_optionsChanged;

int m_optionsWidth;

int m_lastActiveIndex;

@@ -139,6 +136,7 @@ private:

RefPtr<ComputedStyle> m_optionStyle;

RefPtrWillBePersistent<PopupMenu> m_popup;

+ bool m_popupIsVisible;

int m_indexToSelectOnCancel;

// TODO(tkent): Use FRIEND_TEST macro provided by gtest_prod.h