Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: chrome/common/extensions/api/extension_action/action_info.cc

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_action/action_info.cc
diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc
index 8cf0386d3613ed37f4524ca95cfa98975ac805c4..4283c5d1c4703b3b35f358d7c8a12c64687641a7 100644
--- a/chrome/common/extensions/api/extension_action/action_info.cc
+++ b/chrome/common/extensions/api/extension_action/action_info.cc
@@ -182,6 +182,11 @@ scoped_ptr<ActionInfo> ActionInfo::Load(const Extension* extension,
}
}
+ // Should open popup in sidebar?
+ if (!dict->GetBoolean(keys::kPageActionOpenInSidebar,
+ &result->open_in_sidebar))
+ result->open_in_sidebar = false;
+
return result.Pass();
}

Powered by Google App Engine
This is Rietveld 408576698