chrome/common/extensions/api/extension_action/action_info.h - Issue 1152613003: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/action_info.h

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/sidebar_manager.cc ('K') | « chrome/common/extensions/api/developer_private.idl ('k') | chrome/common/extensions/api/extension_action/action_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/action_info.h

diff --git a/chrome/common/extensions/api/extension_action/action_info.h b/chrome/common/extensions/api/extension_action/action_info.h

index 09e497c6b93d8bd2a75bebba562a1a1714d2fa3b..c48d85a947d2a39b448f1971a5b6a346f8621724 100644

--- a/chrome/common/extensions/api/extension_action/action_info.h

+++ b/chrome/common/extensions/api/extension_action/action_info.h

@@ -65,6 +65,7 @@ struct ActionInfo {

GURL default_popup_url;

// action id -- only used with legacy page actions API.

std::string id;

+ bool open_in_sidebar;

};

} // namespace extensions