chrome/browser/ui/browser_ui_prefs.cc - Issue 1152613003: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_ui_prefs.cc

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_ui_prefs.cc

diff --git a/chrome/browser/ui/browser_ui_prefs.cc b/chrome/browser/ui/browser_ui_prefs.cc

index 13bef78bfde29ce8baa556c92719554dc0c5cfb8..4e2dc6da417556278a803fd7f5a6248139ebc2c8 100644

--- a/chrome/browser/ui/browser_ui_prefs.cc

+++ b/chrome/browser/ui/browser_ui_prefs.cc

@@ -17,6 +17,7 @@ namespace chrome {

void RegisterBrowserPrefs(PrefRegistrySimple* registry) {

registry->RegisterIntegerPref(prefs::kOptionsWindowLastTabIndex, 0);

+ registry->RegisterIntegerPref(prefs::kExtensionSidebarWidth, -1);

registry->RegisterBooleanPref(prefs::kAllowFileSelectionDialogs, true);

registry->RegisterIntegerPref(prefs::kShowFirstRunBubbleOption,

first_run::FIRST_RUN_BUBBLE_DONT_SHOW);

« chrome/browser/extensions/sidebar_manager.cc ('K') | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »