chrome/browser/ui/browser.cc - Issue 1152613003: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 1133a6fcb21540402c588dc94b548830e7f73d6b..515c09a115b418898b3eb6bcbada96af9d820523 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -2435,7 +2435,8 @@ bool Browser::SupportsWindowFeatureImpl(WindowFeature feature,

bool check_fullscreen) const {

bool hide_ui_for_fullscreen = check_fullscreen && ShouldHideUIForFullscreen();

- unsigned int features = FEATURE_INFOBAR | FEATURE_DOWNLOADSHELF;

+ unsigned int features =

+ FEATURE_INFOBAR | FEATURE_DOWNLOADSHELF | FEATURE_SIDEBAR;

if (is_type_tabbed())

features |= FEATURE_BOOKMARKBAR;

« chrome/browser/extensions/sidebar_manager.cc ('K') | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_ui_prefs.cc » ('j') | no next file with comments »