Issue 1152603002: Address Ian's comments on layout2.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1152603002: Address Ian's comments on layout2.dart (Closed)

Created:
5 years, 7 months ago by abarth-chromium

Modified:
5 years, 7 months ago

Reviewers:
Hixie

CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -36 lines)			Patch
	M	sky/examples/raw/simple_render_tree.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	sky/sdk/lib/framework/layout2.dart	View		9 chunks	+31 lines, -34 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 7 months ago (2015-05-21 20:32:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9532719c48937fe889c551cc30f7f7733809f250 (presubmit successful).