Address Ian's comments on layout2.dart

sky/sdk/lib/framework/layout2.dart

 library layout;
 
 // This version of layout.dart is an update to the other one, this one using new APIs.
 // It will not work in a stock Sky setup currently.
 
 import 'node.dart';
 
 import 'dart:sky' as sky;
 
 // ABSTRACT LAYOUT
@@ skipping 383 matching lines @@
 // GENERIC BOX RENDERING
 // Anything that has a concept of x, y, width, height is going to derive from this
 
 class BoxConstraints {
   const BoxConstraints({
     this.minWidth: 0.0,
     this.maxWidth: double.INFINITY,
     this.minHeight: 0.0,
     this.maxHeight: double.INFINITY});
 
+  const BoxConstraints.tight({ width: width, height: height })
+    : minWidth = width,
+      maxWidth = width,
+      minHeight = height,
+      maxHeight = height;
+
   final double minWidth;
   final double maxWidth;
   final double minHeight;
   final double maxHeight;
+
+  double constrainWidth(double width) {
+    return clamp(min: minWidth, max: maxWidth, value: width);
+  }
+
+  double constrainHeight(double height) {
+    return clamp(min: minHeight, max: maxHeight, value: height);
+  }
 }
 
 class BoxDimensions {
   const BoxDimensions({this.width, this.height});
 
   BoxDimensions.withConstraints(
       BoxConstraints constraints, {double width: 0.0, double height: 0.0}) {
-    this.width = clamp(min: minWidth, max: maxWidth, value: width);
-    this.height = clamp(min: minHeight, max: maxHeight, value: height);
+    this.width = constraints.constrainWidth(width);
+    this.height = constraints.constrainHeight(height);
   }
 
   final double width;
   final double height;
 }
 
 class BoxParentData extends ParentData {
   double x = 0.0;
   double y = 0.0;
 }
 
 abstract class RenderBox extends RenderNode {
 
   void setParentData(RenderNode child) {
     if (child.parentData is! BoxParentData)
       child.parentData = new BoxParentData();
   }
 
   // override this to report what dimensions you would have if you
   // were laid out with the given constraints this can walk the tree
   // if it must, but it should be as cheap as possible; just get the
   // dimensions and nothing else (e.g. don't calculate hypothetical
   // child positions if they're not needed to determine dimensions)
   BoxDimensions getIntrinsicDimensions(BoxConstraints constraints) {
     return new BoxDimensions.withConstraints(constraints);
   }
 
   void layout(BoxConstraints constraints, { RenderNode relayoutSubtreeRoot }) {
-    setWidth(constraints, 0.0);
-    setHeight(constraints, 0.0);
+    width = constraints.constrainWidth(0.0);
+    height = constraints.constrainHeight(0.0);
     layoutDone();
   }
 
   double width;
   double height;
-
-  void setWidth(BoxConstraints constraints, double newWidth) {
-    width = clamp(min: constraints.minWidth,
-                  max: constraints.maxWidth,
-                  value: newWidth);
-  }
-
-  void setHeight(BoxConstraints constraints, double newHeight) {
-    height = clamp(min: constraints.minHeight,
-                   max: constraints.maxHeight,
-                   value: newHeight);
-  }
 }
 
 class BoxDecoration {
-  BoxDecoration({
+  const BoxDecoration({
     this.backgroundColor
   });
 
   final int backgroundColor;
 }
 
 class RenderDecoratedBox extends RenderBox {
   BoxDecoration _decoration;
 
   RenderDecoratedBox(BoxDecoration decoration) : _decoration = decoration;
@@ skipping 143 matching lines @@
       child.parentData = new BlockParentData();
   }
 
   // override this to report what dimensions you would have if you
   // were laid out with the given constraints this can walk the tree
   // if it must, but it should be as cheap as possible; just get the
   // dimensions and nothing else (e.g. don't calculate hypothetical
   // child positions if they're not needed to determine dimensions)
   BoxDimensions getIntrinsicDimensions(BoxConstraints constraints) {
     double outerHeight = _padding.top + _padding.bottom;
-    // TODO(abarth): Shouldn't this have a value: maxWidth?
-    double outerWidth = clamp(min: constraints.minWidth,
-                              max: constraints.maxWidth);
+    double outerWidth = constraints.constrainWidth(constraints.maxWidth);
+    assert(outerWidth < double.INFINITY);
     double innerWidth = outerWidth - (_padding.left + _padding.right);
     RenderBox child = _firstChild;
     BoxConstraints constraints = new BoxConstraints(minWidth: innerWidth,
                                                     maxWidth: innerWidth);
     while (child != null) {
       outerHeight += child.getIntrinsicDimensions(constraints).height;
       assert(child.parentData is BlockParentData);
       child = child.parentData.nextSibling;
     }
 
-    return new BoxDimensions(
-      width: outerWidth,
-      height: clamp(min: constraints.minHeight,
-                    max: constraints.maxHeight,
-                    value: outerHeight)
-    );
+    return new BoxDimensions(width: outerWidth,
+                             height: constraints.constrainHeight(outerHeight));
   }
 
   double _minHeight; // value cached from parent for relayout call
   double _maxHeight; // value cached from parent for relayout call
   void layout(BoxConstraints constraints, { RenderNode relayoutSubtreeRoot }) {
     if (relayoutSubtreeRoot != null)
       saveRelayoutSubtreeRoot(relayoutSubtreeRoot);
     relayoutSubtreeRoot = relayoutSubtreeRoot == null ? this : relayoutSubtreeRoot;
-    // TODO(abarth): Shouldn't this be setWidth(constaints, constraints.maxWidth)?
-    width = clamp(min: constraints.minWidth, max: constraints.maxWidth);
+    width = constraints.constrainWidth(constraints.maxWidth);
+    assert(width < double.INFINITY);
     _minHeight = constraints.minHeight;
     _maxHeight = constraints.maxHeight;
     internalLayout(relayoutSubtreeRoot);
   }
 
   void relayout() {
     internalLayout(this);
   }
 
   void internalLayout(RenderNode relayoutSubtreeRoot) {
     assert(_minHeight != null);
     assert(_maxHeight != null);
     double y = _padding.top;
     double innerWidth = width - (_padding.left + _padding.right);
     RenderBox child = _firstChild;
     while (child != null) {
       child.layout(new BoxConstraints(minWidth: innerWidth, maxWidth: innerWidth),
                    relayoutSubtreeRoot: relayoutSubtreeRoot);
       assert(child.parentData is BlockParentData);
-      child.parentData.x = 0.0; // TODO(abarth): Shouldn't this be _padding.left?
+      child.parentData.x = _padding.left;
       child.parentData.y = y;
       y += child.height;
       child = child.parentData.nextSibling;
     }
     height = clamp(min: _minHeight, value: y + _padding.bottom, max: _maxHeight);
     layoutDone();
   }
 
   bool handlePointer(sky.PointerEvent event, { double x: 0.0, double y: 0.0 }) {
     // the x, y parameters have the top left of the node's box as the origin
@@ skipping 46 matching lines @@
   ScaffoldBox(this.toolbar, this.body, this.statusbar, this.drawer) {
     assert(body != null);
   }
 
   final RenderBox toolbar;
   final RenderBox body;
   final RenderBox statusbar;
   final RenderBox drawer;
 
   void layout(BoxConstraints constraints, { RenderNode relayoutSubtreeRoot }) {
-    setHeight(constraints, 0.0);
-    setWidth(constraints, 0.0);
+    width = constraints.constrainWidth(0.0);
+    height = constraints.constrainHeight(0.0);
     relayout();
   }
 
   static const kToolbarHeight = 100.0;
   static const kStatusbarHeight = 50.0;
 
   void relayout() {
     double bodyHeight = height;
     if (toolbar != null) {
-      toolbar.layout(new BoxConstraints(minWidth: width, maxWidth: width, minHeight: kToolbarHeight, maxHeight: kToolbarHeight));
+      toolbar.layout(new BoxConstraints.tight(width: width, height: kToolbarHeight));
       assert(toolbar.parentData is BoxParentData);
       toolbar.parentData.x = 0.0;
       toolbar.parentData.y = 0.0;
       bodyHeight -= kToolbarHeight;
     }
     if (statusbar != null) {
-      statusbar.layout(new BoxConstraints(minWidth: width, maxWidth: width, minHeight: kStatusbarHeight, maxHeight: kStatusbarHeight));
+      statusbar.layout(new BoxConstraints.tight(width: width, height: kStatusbarHeight));
       assert(statusbar.parentData is BoxParentData);
       statusbar.parentData.x = 0.0;
       statusbar.parentData.y = height - kStatusbarHeight;
       bodyHeight -= kStatusbarHeight;
     }
-    body.layout(new BoxConstraints(minWidth: width, maxWidth: width, minHeight: bodyHeight, maxHeight: bodyHeight));
+    body.layout(new BoxConstraints.tight(width: width, height: bodyHeight));
     if (drawer != null)
       drawer.layout(new BoxConstraints(minWidth: 0.0, maxWidth: width, minHeight: height, maxHeight: height));
     layoutDone();
   }
 
   bool handlePointer(sky.PointerEvent event, { double x: 0.0, double y: 0.0 }) {
     if ((drawer != null) && (x < drawer.width)) {
       if (drawer.handlePointer(event, x: x, y: y))
         return true;
     } else if ((toolbar != null) && (y < toolbar.height)) {
@@ skipping 13 matching lines @@
     canvas.paintChild(body, (body.parentData as BoxParentData).x, (body.parentData as BoxParentData).y);
     if (statusbar != null)
       canvas.paintChild(statusbar, (statusbar.parentData as BoxParentData).x, (statusbar.parentData as BoxParentData).y);
     if (toolbar != null)
       canvas.paintChild(toolbar, (toolbar.parentData as BoxParentData).x, (toolbar.parentData as BoxParentData).y);
     if (drawer != null)
       canvas.paintChild(drawer, (drawer.parentData as BoxParentData).x, (drawer.parentData as BoxParentData).y);
   }
 
 }