remoting/compile_js.gypi - Issue 1152583011: Refactor compile_js.gypi to support script_args and closure_args

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/compile_js.gypi

Issue 1152583011: Refactor compile_js.gypi to support script_args and closure_args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove --success_stamp, use gypi closure args in compile_test.py Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/resources/enhanced_bookmarks/enhanced_bookmarks.gypi ('k') | remoting/remoting_key_tester.gypi » ('j') | third_party/closure_compiler/compiler_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/compile_js.gypi

diff --git a/remoting/compile_js.gypi b/remoting/compile_js.gypi

new file mode 100644

index 0000000000000000000000000000000000000000..1a92cdd39762f957726517798064f1e4568d5d82

--- /dev/null

+++ b/remoting/compile_js.gypi

@@ -0,0 +1,17 @@

+# Use of this source code is governed by a BSD-style license that can be

+# found in the LICENSE file.

+ 'variables': {

+ 'externs': ['<(DEPTH)/third_party/closure_compiler/externs/chrome_extensions.js'],

Dan Beam 2015/06/04 20:45:56 nit: <(DEPTH) -> ..

Theresa 2015/06/04 23:06:09 Done.

+ 'script_args': ['--no-single-file'],

+ 'closure_args': [

+ 'jscomp_error=reportUnknownTypes',

+ 'jscomp_error=duplicate',

+ 'jscomp_error=misplacedTypeAnnotation',

+ ],

+ 'disabled_closure_args': [],

+ },

+ 'includes': ['../third_party/closure_compiler/compile_js.gypi'],