remoting/compile_js.gypi - Issue 1152583011: Refactor compile_js.gypi to support script_args and closure_args

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/compile_js.gypi

Issue 1152583011: Refactor compile_js.gypi to support script_args and closure_args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove --success_stamp, use gypi closure args in compile_test.py Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/resources/enhanced_bookmarks/enhanced_bookmarks.gypi ('k') | remoting/remoting_key_tester.gypi » ('j') | third_party/closure_compiler/compiler_test.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'variables': {

	7 'externs': ['<(DEPTH)/third_party/closure_compiler/externs/chrome_extensions .js'],
	Dan Beam 2015/06/04 20:45:56 nit: <(DEPTH) -> .. nit: <(DEPTH) -> .. Theresa 2015/06/04 23:06:09 Done. Show quoted text On 2015/06/04 20:45:56, Dan Beam wrote: > nit: <(DEPTH) -> .. Done.
	8 'script_args': ['--no-single-file'],

	9 'closure_args': [

	10 'jscomp_error=reportUnknownTypes',

	11 'jscomp_error=duplicate',

	12 'jscomp_error=misplacedTypeAnnotation',

	13 ],

	14 'disabled_closure_args': [],

	15 },

	16 'includes': ['../third_party/closure_compiler/compile_js.gypi'],

	17 }

OLD	NEW