Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 1152523004: Clean PrepareForScavenge

Created:
5 years, 7 months ago by sejunho
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean PrepareForScavenge This method requires pretty much cost(milliseconds per 1MB), but no more needed. Until the last year, marking deque used from-space for marking_deque_memory. So, cleaning from-space was needed. But now, marking deque does not use from-space any more. previous patch: Use just one marking deque. https://codereview.chromium.org/770453003 1. Two marking deque(incremental, mark-compact) merged into one. 2. The memory space is changed from from-space to new virtual memory. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
sejunho
Hi payer, please take a look :)
5 years, 7 months ago (2015-05-27 05:51:59 UTC) #2
sejunho
Hello, I worked on GC, and send my patch for review. Take a look, please ...
5 years, 7 months ago (2015-05-28 02:42:52 UTC) #3
Hannes Payer (out of office)
no lgtm, the marking deque has (and had) nothing to do with the mark bits.
5 years, 7 months ago (2015-05-28 07:48:40 UTC) #4
Hannes Payer (out of office)
On 2015/05/28 07:48:40, Hannes Payer wrote: > no lgtm, the marking deque has (and had) ...
5 years, 7 months ago (2015-05-28 07:50:38 UTC) #5
sejunho
On 2015/05/28 07:50:38, Hannes Payer wrote: > On 2015/05/28 07:48:40, Hannes Payer wrote: > > ...
5 years, 7 months ago (2015-05-28 08:37:30 UTC) #6
Hannes Payer (out of office)
On 2015/05/28 08:37:30, sejunho wrote: > On 2015/05/28 07:50:38, Hannes Payer wrote: > > On ...
5 years, 7 months ago (2015-05-28 09:38:33 UTC) #7
sejunho
5 years, 7 months ago (2015-05-28 09:49:51 UTC) #8
On 2015/05/28 09:38:33, Hannes Payer wrote:
> On 2015/05/28 08:37:30, sejunho wrote:
> > On 2015/05/28 07:50:38, Hannes Payer wrote:
> > > On 2015/05/28 07:48:40, Hannes Payer wrote:
> > > > no lgtm, the marking deque has (and had) nothing to do with the mark
bits.
> > > 
> > > not lgtm
> > 
> > Thank you for taking the time to review. I will keep trying.
> 
> But thanks for looking into this. After staring at the code I realized that we
> clear the mark bits on two locations, which is not needed. We should fix that.


Is 'two locations' means PrepareForScavenge in incremental-marking and
ResetAllocationInfo
in NewSpace? If that right, I will work for fix that. I will modify description
and submit
another CL  :)

Powered by Google App Engine
This is Rietveld 408576698