Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 770453003: Use just one marking deque. (Closed)

Created:
6 years ago by Hannes Payer (out of office)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Use just one marking deque. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 2

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -98 lines) Patch
M src/heap/heap.cc View 1 2 3 4 5 6 7 4 chunks +4 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.h View 5 6 7 8 5 chunks +0 lines, -14 lines 0 comments Download
M src/heap/incremental-marking.cc View 5 6 7 8 13 chunks +23 lines, -53 lines 0 comments Download
M src/heap/incremental-marking-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 3 5 6 7 8 2 chunks +10 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 5 6 7 8 5 chunks +52 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jochen (gone - plz use gerrit)
is it possible to avoid marking everybody friend of everybody else? I think exposing the ...
6 years ago (2014-12-01 14:32:04 UTC) #2
Hannes Payer (out of office)
I unfriended them. https://codereview.chromium.org/770453003/diff/100001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/770453003/diff/100001/src/heap/mark-compact.cc#newcode2033 src/heap/mark-compact.cc:2033: DCHECK(!Marking::IsWhite(Marking::MarkBitFrom(object))); On 2014/12/01 14:32:04, jochen (slow) ...
6 years ago (2014-12-01 14:53:24 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-01 14:55:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770453003/130001
6 years ago (2014-12-01 15:02:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/1527)
6 years ago (2014-12-01 15:59:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770453003/40002
6 years ago (2014-12-01 16:35:28 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-01 17:02:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #9 (id:40002)

Powered by Google App Engine
This is Rietveld 408576698