Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1152523002: Remove v8::Private (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
rossberg
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove v8::Private Nothing uses it R=rossberg@chromium.org LOG=y BUG=none Committed: https://crrev.com/b6ac16dabd67772d73f355e952454fdac603d5e6 Cr-Commit-Position: refs/heads/master@{#28591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -183 lines) Patch
M include/v8.h View 4 chunks +0 lines, -42 lines 0 comments Download
M src/api.cc View 6 chunks +0 lines, -60 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -81 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-21 12:49:16 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 7 months ago (2015-05-21 16:55:46 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152523002/1
5 years, 7 months ago (2015-05-21 16:56:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-21 17:45:44 UTC) #6
rossberg
We probably have to make this come back eventually, but since nobody is working on ...
5 years, 7 months ago (2015-05-22 12:07:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152523002/1
5 years, 7 months ago (2015-05-22 12:10:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 12:42:08 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 12:42:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6ac16dabd67772d73f355e952454fdac603d5e6
Cr-Commit-Position: refs/heads/master@{#28591}

Powered by Google App Engine
This is Rietveld 408576698