Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: include/v8.h

Issue 1152523002: Remove v8::Private (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 06b367056413fa630df133d333d9d356d96f8bdc..9d29e2824673952d0fe76eb5e1150b3fc1b593a7 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -102,7 +102,6 @@ class String;
class StringObject;
class Symbol;
class SymbolObject;
-class Private;
class Uint32;
class Utils;
class Value;
@@ -311,7 +310,6 @@ class Local {
friend class String;
friend class Object;
friend class Context;
- friend class Private;
template<class F> friend class internal::CustomArguments;
friend Local<Primitive> Undefined(Isolate* isolate);
friend Local<Primitive> Null(Isolate* isolate);
@@ -2452,34 +2450,6 @@ class V8_EXPORT Symbol : public Name {
/**
- * A private symbol
- *
- * This is an experimental feature. Use at your own risk.
- */
-class V8_EXPORT Private : public Data {
- public:
- // Returns the print name string of the private symbol, or undefined if none.
- Local<Value> Name() const;
-
- // Create a private symbol. If name is not empty, it will be the description.
- static Local<Private> New(
- Isolate *isolate, Local<String> name = Local<String>());
-
- // Retrieve a global private symbol. If a symbol with this name has not
- // been retrieved in the same isolate before, it is created.
- // Note that private symbols created this way are never collected, so
- // they should only be used for statically fixed properties.
- // Also, there is only one global name space for the names used as keys.
- // To minimize the potential for clashes, use qualified names as keys,
- // e.g., "Class#property".
- static Local<Private> ForApi(Isolate *isolate, Local<String> name);
-
- private:
- Private();
-};
-
-
-/**
* A JavaScript number value (ECMA-262, 4.3.20)
*/
class V8_EXPORT Number : public Primitive {
@@ -2683,18 +2653,6 @@ class V8_EXPORT Object : public Value {
AccessControl settings = DEFAULT);
/**
- * Functionality for private properties.
- * This is an experimental feature, use at your own risk.
- * Note: Private properties are inherited. Do not rely on this, since it may
- * change.
- */
- // TODO(dcarney): convert these or remove?
- bool HasPrivate(Handle<Private> key);
- bool SetPrivate(Handle<Private> key, Handle<Value> value);
- bool DeletePrivate(Handle<Private> key);
- Local<Value> GetPrivate(Handle<Private> key);
-
- /**
* Returns an array containing the names of the enumerable properties
* of this object, including properties from prototype objects. The
* array returned by this method contains the same values as would
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698