tests/gclient_smoketest.py - Issue 1152443004: Add quotes around command line in subproccess error message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gclient_smoketest.py

Issue 1152443004: Add quotes around command line in subproccess error message (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gclient_smoketest.py

diff --git a/tests/gclient_smoketest.py b/tests/gclient_smoketest.py

index 96b507959b9a947dd7d1b58f5d320abcecff6b59..50e7fd72c0ac2d20e2bad5a41bc5a52016f57c6e 100755

--- a/tests/gclient_smoketest.py

+++ b/tests/gclient_smoketest.py

@@ -517,8 +517,8 @@ class GClientSmokeGIT(GClientSmokeBase):

('running', self.root_dir), # pre-deps hook

('running', self.root_dir), # pre-deps hook (fails)

]

- expected_stderr = ('Error: Command /usr/bin/python -c import sys; '

- 'sys.exit(1) returned non-zero exit status 1 in %s\n'

+ expected_stderr = ("Error: Command '/usr/bin/python -c import sys; "

+ "sys.exit(1)' returned non-zero exit status 1 in %s\n"

iannucci 2015/06/01 21:51:58 here too.

Sam Clegg 2015/06/01 21:58:45 Even when embedding single quotes?

% self.root_dir)

stdout, stderr, retcode = self.gclient(['sync', '--deps', 'mac', '--jobs=1',

'--revision',

« subprocess2.py ('K') | « subprocess2.py ('k') | no next file » | no next file with comments »