subprocess2.py - Issue 1152443004: Add quotes around command line in subproccess error message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: subprocess2.py

Issue 1152443004: Add quotes around command line in subproccess error message (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: subprocess2.py

diff --git a/subprocess2.py b/subprocess2.py

index 6e138a503fbbd22340ab74c65f2e4580536ac0ee..258b63774725d96c4f70959a5950a8f635a61ace 100644

--- a/subprocess2.py

+++ b/subprocess2.py

@@ -40,7 +40,7 @@ class CalledProcessError(subprocess.CalledProcessError):

self.cwd = cwd

def __str__(self):

- out = 'Command %s returned non-zero exit status %s' % (

+ out = "Command %r returned non-zero exit status %s" % (

iannucci 2015/06/01 21:51:58 we prefer single quotes in this file, I think.

Sam Clegg 2015/06/01 21:58:45 Done.

' '.join(self.cmd), self.returncode)

if self.cwd:

out += ' in ' + self.cwd

« no previous file with comments | « no previous file | tests/gclient_smoketest.py » ('j') | tests/gclient_smoketest.py » ('J')