Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: Source/core/svg/graphics/SVGImageChromeClient.h

Issue 1152413003: General code cleanup of ChromeClient-related classes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/core/svg/graphics/SVGImageChromeClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/graphics/SVGImageChromeClient.h
diff --git a/Source/core/svg/graphics/SVGImageChromeClient.h b/Source/core/svg/graphics/SVGImageChromeClient.h
index 25ec85c0b4696c2325a67d8cb52f67781a2bcc65..0592bae67ca8a0e39cca08cdabb7a8fe51dbfa54 100644
--- a/Source/core/svg/graphics/SVGImageChromeClient.h
+++ b/Source/core/svg/graphics/SVGImageChromeClient.h
@@ -40,14 +40,14 @@ class SVGImageChromeClient final : public EmptyChromeClient {
WTF_MAKE_NONCOPYABLE(SVGImageChromeClient); WTF_MAKE_FAST_ALLOCATED(SVGImageChromeClient);
public:
explicit SVGImageChromeClient(SVGImage*);
- virtual bool isSVGImageChromeClient() const override;
+ bool isSVGImageChromeClient() const override;
yosin_UTC9 2015/06/03 07:15:27 Q: Do you recommend |override| than |final| in |fi
tkent 2015/06/03 07:22:19 I have no opinion about it. Google C++ style guide
SVGImage* image() const { return m_image; }
private:
- virtual void chromeDestroyed() override;
- virtual void invalidateRect(const IntRect&) override;
- virtual void scheduleAnimation() override;
+ void chromeDestroyed() override;
+ void invalidateRect(const IntRect&) override;
+ void scheduleAnimation() override;
void animationTimerFired(Timer<SVGImageChromeClient>*);
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/core/svg/graphics/SVGImageChromeClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698