Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: Source/core/svg/graphics/SVGImageChromeClient.h

Issue 1152413003: General code cleanup of ChromeClient-related classes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/core/svg/graphics/SVGImageChromeClient.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 22 matching lines...) Expand all
33 #include "platform/Timer.h" 33 #include "platform/Timer.h"
34 34
35 namespace blink { 35 namespace blink {
36 36
37 class SVGImage; 37 class SVGImage;
38 38
39 class SVGImageChromeClient final : public EmptyChromeClient { 39 class SVGImageChromeClient final : public EmptyChromeClient {
40 WTF_MAKE_NONCOPYABLE(SVGImageChromeClient); WTF_MAKE_FAST_ALLOCATED(SVGImage ChromeClient); 40 WTF_MAKE_NONCOPYABLE(SVGImageChromeClient); WTF_MAKE_FAST_ALLOCATED(SVGImage ChromeClient);
41 public: 41 public:
42 explicit SVGImageChromeClient(SVGImage*); 42 explicit SVGImageChromeClient(SVGImage*);
43 virtual bool isSVGImageChromeClient() const override; 43 bool isSVGImageChromeClient() const override;
yosin_UTC9 2015/06/03 07:15:27 Q: Do you recommend |override| than |final| in |fi
tkent 2015/06/03 07:22:19 I have no opinion about it. Google C++ style guide
44 44
45 SVGImage* image() const { return m_image; } 45 SVGImage* image() const { return m_image; }
46 46
47 private: 47 private:
48 virtual void chromeDestroyed() override; 48 void chromeDestroyed() override;
49 virtual void invalidateRect(const IntRect&) override; 49 void invalidateRect(const IntRect&) override;
50 virtual void scheduleAnimation() override; 50 void scheduleAnimation() override;
51 51
52 void animationTimerFired(Timer<SVGImageChromeClient>*); 52 void animationTimerFired(Timer<SVGImageChromeClient>*);
53 53
54 SVGImage* m_image; 54 SVGImage* m_image;
55 Timer<SVGImageChromeClient> m_animationTimer; 55 Timer<SVGImageChromeClient> m_animationTimer;
56 }; 56 };
57 57
58 DEFINE_TYPE_CASTS(SVGImageChromeClient, ChromeClient, client, client->isSVGImage ChromeClient(), client.isSVGImageChromeClient()); 58 DEFINE_TYPE_CASTS(SVGImageChromeClient, ChromeClient, client, client->isSVGImage ChromeClient(), client.isSVGImageChromeClient());
59 59
60 } 60 }
61 61
62 #endif // SVGImageChromeClient_h 62 #endif // SVGImageChromeClient_h
OLDNEW
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/core/svg/graphics/SVGImageChromeClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698