Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1152383002: A proof of concept for annular sector layout. (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

A proof of concept for annular sector layout. Could be useful for watch faces. :-) Includes some minor fixes to layout2.dart. Includes adding a very basic path API. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/86273cda8988253fd671ac306556375a04f1a37c

Patch Set 1 #

Patch Set 2 : merge with collin's recent changes #

Patch Set 3 : Fix analyzer issues. Also, use collin's solution to the BoxDimensions issue (initialisers) instead … #

Patch Set 4 : add the Path C++ and IDL files which I forgot before #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -15 lines) Patch
M sky/engine/core/core.gni View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Canvas.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Canvas.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Canvas.idl View 1 chunk +1 line, -0 lines 0 comments Download
A sky/engine/core/painting/CanvasPath.h View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
A + sky/engine/core/painting/CanvasPath.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A sky/engine/core/painting/Path.idl View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A sky/examples/raw/sector-layout.dart View 1 2 1 chunk +377 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/layout2.dart View 1 2 8 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
git add CanvasPath.* ?
5 years, 7 months ago (2015-05-26 14:05:48 UTC) #2
abarth-chromium
LGTM Very cool!!!
5 years, 7 months ago (2015-05-26 14:09:01 UTC) #3
Hixie
On 2015/05/26 at 14:05:48, abarth wrote: > git add CanvasPath.* ? oops. done.
5 years, 7 months ago (2015-05-26 15:31:26 UTC) #4
Hixie
5 years, 7 months ago (2015-05-26 15:33:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
86273cda8988253fd671ac306556375a04f1a37c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698