Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 115228: Try to fix a crash in Hunspell. (Closed)

Created:
11 years, 7 months ago by jungshik at Google
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Mark Larson
Visibility:
Public.

Description

Fix a crash in Hunspell : 1) initializes cond.utf8 part of affentry and checking whether its elements are populated before calling |free|. 2) Downgrade the French dictionary from 3.0.1 (Jan 2009) to 2.3.2 (Apri, 2008). 3.0.1 has aff entries with more than 8 conditions. Our version of Hunspell only supports up to 8 conditions per Affentry. Newer versions support more than8 conditions. When we update our copy of Hunspell, we'll update our dictionary again. http://crbug.com/8551 TEST=1. Launch Chrome with '--lang=fr' (or set your spellcheck language to French in a textarea) and type random text into a textarea and quit Chrome. Chrome should quit without crashing. 2. In text area, type random text with spell checker set to French and switch to English and switch back to French. Chrome should not Crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16115

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+889 lines, -12398 lines) Patch
M chrome/third_party/hunspell/dictionaries/README.chromium View 5 2 chunks +5 lines, -1 line 0 comments Download
M chrome/third_party/hunspell/dictionaries/README_fr_FR.txt View 1 chunk +299 lines, -383 lines 0 comments Download
D chrome/third_party/hunspell/dictionaries/fr-fr.bdic View Binary file 0 comments Download
M chrome/third_party/hunspell/dictionaries/fr_FR.aff View 2 chunks +574 lines, -12010 lines 0 comments Download
A chrome/third_party/hunspell/dictionaries/fr_FR.bdic View Binary file 0 comments Download
M chrome/third_party/hunspell/src/hunspell/affentry.cxx View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/third_party/hunspell/src/hunspell/affixmgr.cxx View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jungshik at Google
I'm not sure which is better, patch set 1 or 3. Patch set 3 tries ...
11 years, 7 months ago (2009-05-12 23:12:48 UTC) #1
brettw
I think the calloc is fine since this is only called once ever. I checked ...
11 years, 7 months ago (2009-05-12 23:22:08 UTC) #2
jungshik at Google
Sid and Brett, Can you take another look?
11 years, 7 months ago (2009-05-14 19:58:21 UTC) #3
brettw
LGTM
11 years, 7 months ago (2009-05-14 20:10:44 UTC) #4
jungshik at Google
11 years, 7 months ago (2009-05-14 20:10:58 UTC) #5
On 2009/05/14 19:58:21, Jungshik Shin wrote:
> Sid and Brett, Can you take another look?

BTW, fr_FR.dic is not uploaded here because it's too large (gcl refuses to
upload it :-)). I'll make a patch for 172 branch separately and check that in.
Well, this does not matter much (for the branch) because what matter is updating
 the bdic file from the download server.

Powered by Google App Engine
This is Rietveld 408576698