Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1152243002: Do not patch IC in deoptimized code. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev, Jarin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not patch IC in deoptimized code. R=mvstanton@chromium.org Committed: https://crrev.com/61a5962bd3b8ba75c3529cec2aee8bbaad536336 Cr-Commit-Position: refs/heads/master@{#28607}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove unused declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M src/ic/ic.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/ic.cc View 2 chunks +1 line, -8 lines 0 comments Download
M src/ic/ic-inl.h View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 7 months ago (2015-05-22 14:11:03 UTC) #1
mvstanton
LGTM.
5 years, 7 months ago (2015-05-22 14:12:28 UTC) #2
Jakob Kummerow
DBC. https://codereview.chromium.org/1152243002/diff/1/src/ic/ic.h File src/ic/ic.h (right): https://codereview.chromium.org/1152243002/diff/1/src/ic/ic.h#newcode257 src/ic/ic.h:257: inline static bool CheckForLazyDeopt(Isolate* isolate, Address address); unused?
5 years, 7 months ago (2015-05-22 16:18:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152243002/20001
5 years, 7 months ago (2015-05-26 06:16:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-26 06:56:21 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 06:56:31 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/61a5962bd3b8ba75c3529cec2aee8bbaad536336
Cr-Commit-Position: refs/heads/master@{#28607}

Powered by Google App Engine
This is Rietveld 408576698