Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: src/ic/ic.h

Issue 1152243002: Do not patch IC in deoptimized code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_H_ 5 #ifndef V8_IC_H_
6 #define V8_IC_H_ 6 #define V8_IC_H_
7 7
8 #include "src/ic/ic-state.h" 8 #include "src/ic/ic-state.h"
9 #include "src/macro-assembler.h" 9 #include "src/macro-assembler.h"
10 #include "src/messages.h" 10 #include "src/messages.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 Isolate* isolate() const { return isolate_; } 127 Isolate* isolate() const { return isolate_; }
128 128
129 // Get the shared function info of the caller. 129 // Get the shared function info of the caller.
130 SharedFunctionInfo* GetSharedFunctionInfo() const; 130 SharedFunctionInfo* GetSharedFunctionInfo() const;
131 // Get the code object of the caller. 131 // Get the code object of the caller.
132 Code* GetCode() const; 132 Code* GetCode() const;
133 // Get the original (non-breakpointed) code object of the caller. 133 // Get the original (non-breakpointed) code object of the caller.
134 Code* GetOriginalCode() const; 134 Code* GetOriginalCode() const;
135 135
136 bool AddressIsOptimizedCode() const; 136 bool AddressIsOptimizedCode() const;
137 bool AddressIsDeoptimizedCode() const; 137 inline bool AddressIsDeoptimizedCode() const;
138 inline static bool AddressIsDeoptimizedCode(Isolate* isolate,
139 Address address);
138 140
139 // Set the call-site target. 141 // Set the call-site target.
140 inline void set_target(Code* code); 142 inline void set_target(Code* code);
141 bool is_target_set() { return target_set_; } 143 bool is_target_set() { return target_set_; }
142 bool is_vector_set() { return vector_set_; } 144 bool is_vector_set() { return vector_set_; }
143 145
144 bool UseVector() const { 146 bool UseVector() const {
145 bool use = ICUseVector(kind()); 147 bool use = ICUseVector(kind());
146 // If we are supposed to use the nexus, verify the nexus is non-null. 148 // If we are supposed to use the nexus, verify the nexus is non-null.
147 DCHECK(!use || nexus_ != NULL); 149 DCHECK(!use || nexus_ != NULL);
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 } 247 }
246 248
247 template <class NexusClass> 249 template <class NexusClass>
248 NexusClass* casted_nexus() { 250 NexusClass* casted_nexus() {
249 return static_cast<NexusClass*>(nexus_); 251 return static_cast<NexusClass*>(nexus_);
250 } 252 }
251 FeedbackNexus* nexus() const { return nexus_; } 253 FeedbackNexus* nexus() const { return nexus_; }
252 254
253 inline Code* get_host(); 255 inline Code* get_host();
254 256
257 inline static bool CheckForLazyDeopt(Isolate* isolate, Address address);
Jakob Kummerow 2015/05/22 16:18:24 unused?
258
255 private: 259 private:
256 inline Code* raw_target() const; 260 inline Code* raw_target() const;
257 inline ConstantPoolArray* constant_pool() const; 261 inline ConstantPoolArray* constant_pool() const;
258 inline ConstantPoolArray* raw_constant_pool() const; 262 inline ConstantPoolArray* raw_constant_pool() const;
259 263
260 void FindTargetMaps() { 264 void FindTargetMaps() {
261 if (target_maps_set_) return; 265 if (target_maps_set_) return;
262 target_maps_set_ = true; 266 target_maps_set_ = true;
263 if (UseVector()) { 267 if (UseVector()) {
264 nexus()->ExtractMaps(&target_maps_); 268 nexus()->ExtractMaps(&target_maps_);
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
742 746
743 // Support functions for interceptor handlers. 747 // Support functions for interceptor handlers.
744 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptorOnly); 748 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptorOnly);
745 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptor); 749 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptor);
746 DECLARE_RUNTIME_FUNCTION(LoadElementWithInterceptor); 750 DECLARE_RUNTIME_FUNCTION(LoadElementWithInterceptor);
747 DECLARE_RUNTIME_FUNCTION(StorePropertyWithInterceptor); 751 DECLARE_RUNTIME_FUNCTION(StorePropertyWithInterceptor);
748 } 752 }
749 } // namespace v8::internal 753 } // namespace v8::internal
750 754
751 #endif // V8_IC_H_ 755 #endif // V8_IC_H_
OLDNEW
« no previous file with comments | « no previous file | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698